Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: completion event was lost when an error occurred #525

Conversation

welkeyever
Copy link
Member

@welkeyever welkeyever commented Jan 9, 2023

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

修复发生错误时 trace 完成事件丢失的问题(读header/body & 写header/body)

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: fix the issue where the completion event was lost when an error occurred && add UTs
zh(optional): 修复错误发生时完成事件丢失的问题 && 添加单测

Which issue(s) this PR fixes:

None

@welkeyever welkeyever requested review from a team as code owners January 9, 2023 13:35
pkg/protocol/http1/server.go Outdated Show resolved Hide resolved
@welkeyever welkeyever force-pushed the fix/missing_write_finish_event_when_error_happen branch from daf62e0 to 8ba0503 Compare January 9, 2023 13:45
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 69.34% // Head: 70.97% // Increases project coverage by +1.62% 🎉

Coverage data is based on head (b6eb212) compared to base (81332e6).
Patch coverage: 86.95% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #525      +/-   ##
===========================================
+ Coverage    69.34%   70.97%   +1.62%     
===========================================
  Files           93       93              
  Lines         8874     8926      +52     
===========================================
+ Hits          6154     6335     +181     
+ Misses        2355     2202     -153     
- Partials       365      389      +24     
Impacted Files Coverage Δ
pkg/protocol/http1/server.go 62.31% <86.95%> (+62.31%) ⬆️
pkg/network/netpoll/connection.go 73.33% <0.00%> (-7.16%) ⬇️
pkg/app/fs.go 68.65% <0.00%> (ø)
pkg/app/context.go 84.30% <0.00%> (ø)
pkg/protocol/request.go 83.24% <0.00%> (ø)
pkg/app/client/client.go 74.39% <0.00%> (ø)
pkg/common/ut/request.go 93.10% <0.00%> (ø)
pkg/route/routergroup.go 77.06% <0.00%> (ø)
pkg/common/errors/errors.go 87.95% <0.00%> (ø)
pkg/app/server/binding/binding.go 81.81% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@welkeyever welkeyever force-pushed the fix/missing_write_finish_event_when_error_happen branch from 8ba0503 to 6e7f58d Compare January 10, 2023 06:38
@welkeyever welkeyever force-pushed the fix/missing_write_finish_event_when_error_happen branch 2 times, most recently from b0a7946 to 2b66a54 Compare January 10, 2023 13:32
@welkeyever welkeyever force-pushed the fix/missing_write_finish_event_when_error_happen branch from 2b66a54 to b6eb212 Compare January 11, 2023 03:17
@welkeyever welkeyever merged commit 0aa3438 into cloudwego:develop Jan 17, 2023
@welkeyever welkeyever deleted the fix/missing_write_finish_event_when_error_happen branch January 17, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants