-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: completion event was lost when an error occurred #525
fix: completion event was lost when an error occurred #525
Conversation
daf62e0
to
8ba0503
Compare
Codecov ReportBase: 69.34% // Head: 70.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #525 +/- ##
===========================================
+ Coverage 69.34% 70.97% +1.62%
===========================================
Files 93 93
Lines 8874 8926 +52
===========================================
+ Hits 6154 6335 +181
+ Misses 2355 2202 -153
- Partials 365 389 +24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
8ba0503
to
6e7f58d
Compare
b0a7946
to
2b66a54
Compare
2b66a54
to
b6eb212
Compare
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
修复发生错误时 trace 完成事件丢失的问题(读header/body & 写header/body)
(Optional) More detail description for this PR(en: English/zh: Chinese).
en: fix the issue where the completion event was lost when an error occurred && add UTs
zh(optional): 修复错误发生时完成事件丢失的问题 && 添加单测
Which issue(s) this PR fixes:
None