fix(hz): base type error and multiple service error for client #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 69.34% // Head: 69.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #510 +/- ##
===========================================
+ Coverage 69.34% 69.42% +0.07%
===========================================
Files 93 93
Lines 8874 8874
===========================================
+ Hits 6154 6161 +7
+ Misses 2355 2348 -7
Partials 365 365
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
li-jin-gou
approved these changes
Jan 4, 2023
Duslia
approved these changes
Jan 4, 2023
welkeyever
reviewed
Jan 4, 2023
| @@ -142,7 +142,8 @@ func (pkgGen *HttpPackageGenerator) Generate(pkg *HttpPackage) error { | |||
|
|
|||
| if pkgGen.CmdType == meta.CmdClient { | |||
| clientDir := pkgGen.IdlClientDir | |||
| clientDir = util.SubDir(clientDir, "hertz") | |||
| // support multiple service, so disable "clientDir/hertz" | |||
| // clientDir = util.SubDir(clientDir, "hertz") | |||
There was a problem hiding this comment.
Why not just delete this line?
There was a problem hiding this comment.
Do it in another pr, this one has been merged~
welkeyever
reviewed
Jan 4, 2023
| @@ -43,7 +43,8 @@ type ClientFile struct { | |||
|
|
|||
| func (pkgGen *HttpPackageGenerator) genClient(pkg *HttpPackage, clientDir string) error { | |||
| for _, s := range pkg.Services { | |||
| hertzClientPath := filepath.Join(clientDir, "hertz_client.go") | |||
| cliDir := util.SubDir(clientDir, util.ToSnakeCase(s.Name)) | |||
| hertzClientPath := filepath.Join(cliDir, "hertz_client.go") | |||
There was a problem hiding this comment.
Add a const for hertz_client.go?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
修复 hz 生成的 client 代码在使用基本类型作为入参时的错误，以及定义多 service 时出现的错误
(Optional) More detail description for this PR(en: English/zh: Chinese).
en: Fix a bug in hz-generated client code when using basic types as input, and when defining multiple services
zh(optional):
修复 hz 生成的 client 代码在使用基本类型作为入参时的错误，以及定义多 service 时出现的错误
Which issue(s) this PR fixes: