Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hz): hz template #484

Merged
merged 5 commits into from
Jan 11, 2023
Merged

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Dec 22, 2022

What type of PR is this?

refactor

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

重构 hz 生成的代码的模板

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: refactor hz template for generating code more flexibly
zh(optional): 1. 添加了自定义 package 文件模板功能 2. 添加了覆盖模板机制,写模板的时候可以不用全量写默认模板 3. 增加对同一个文件增量更新的逻辑

Which issue(s) this PR fixes:

@FGYFFFF FGYFFFF requested review from a team as code owners December 22, 2022 09:28
@FGYFFFF FGYFFFF changed the title [WIP] refactor: hz template [WIP]refactor(hz): hz template Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 69.75% // Head: 69.87% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (d62df4b) compared to base (67eb00d).
Patch has no changes to coverable lines.

❗ Current head d62df4b differs from pull request most recent head db40919. Consider uploading reports for the commit db40919 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #484      +/-   ##
===========================================
+ Coverage    69.75%   69.87%   +0.12%     
===========================================
  Files           93       93              
  Lines         8878     8887       +9     
===========================================
+ Hits          6193     6210      +17     
+ Misses        2315     2307       -8     
  Partials       370      370              
Impacted Files Coverage Δ
pkg/protocol/header.go 75.59% <0.00%> (+0.65%) ⬆️
pkg/protocol/cookie.go 88.47% <0.00%> (+2.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FGYFFFF FGYFFFF force-pushed the refactor/template branch 9 times, most recently from 46af744 to e8db3fd Compare December 27, 2022 07:04
@FGYFFFF FGYFFFF changed the title [WIP]refactor(hz): hz template refactor(hz): hz template Dec 27, 2022
li-jin-gou
li-jin-gou previously approved these changes Dec 27, 2022
Duslia
Duslia previously approved these changes Jan 9, 2023
@Duslia Duslia self-requested a review January 9, 2023 07:11
@Duslia Duslia closed this Jan 9, 2023
@Duslia Duslia reopened this Jan 9, 2023
@FGYFFFF FGYFFFF force-pushed the refactor/template branch from e843f4b to b746e56 Compare January 9, 2023 08:45
Duslia
Duslia previously approved these changes Jan 11, 2023
wzekin
wzekin previously approved these changes Jan 11, 2023
@li-jin-gou li-jin-gou dismissed stale reviews from wzekin and Duslia via db40919 January 11, 2023 06:54
@welkeyever welkeyever merged commit e0c6299 into cloudwego:develop Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants