Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add WithDialFunc for client #447

Merged
merged 3 commits into from
Dec 22, 2022

Conversation

li-jin-gou
Copy link
Member

@li-jin-gou li-jin-gou commented Dec 3, 2022

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

Client 添加 WithDialFunc

Which issue(s) this PR fixes:

#445 (comment)

@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Base: 69.61% // Head: 69.64% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (c505c4c) compared to base (257685e).
Patch coverage: 78.26% of modified lines in pull request are covered.

❗ Current head c505c4c differs from pull request most recent head 6ab76b3. Consider uploading reports for the commit 6ab76b3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #447      +/-   ##
===========================================
+ Coverage    69.61%   69.64%   +0.03%     
===========================================
  Files           93       93              
  Lines         8752     8774      +22     
===========================================
+ Hits          6093     6111      +18     
- Misses        2297     2299       +2     
- Partials       362      364       +2     
Impacted Files Coverage Δ
pkg/app/server/option.go 98.55% <71.42%> (-1.45%) ⬇️
pkg/app/client/option.go 96.51% <78.57%> (-3.49%) ⬇️
pkg/common/config/option.go 100.00% <100.00%> (ø)
pkg/route/engine.go 63.19% <100.00%> (ø)
pkg/common/compress/compress.go 80.95% <0.00%> (-2.86%) ⬇️
pkg/common/timer/timer.go 80.95% <0.00%> (+19.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/app/client/option.go Outdated Show resolved Hide resolved
pkg/app/client/option.go Outdated Show resolved Hide resolved
@li-jin-gou li-jin-gou force-pushed the optimize/dial_func branch 2 times, most recently from 1d79260 to f169bee Compare December 7, 2022 13:26
@kolinfluence
Copy link

is this merging? having trouble with existing reverse proxy feature with h2

@FGYFFFF FGYFFFF requested review from a team as code owners December 21, 2022 03:30
@li-jin-gou li-jin-gou merged commit ce6ab72 into cloudwego:develop Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants