Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more tests for pkg/app/middlewares/server/basic_auth #405

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

mamil
Copy link
Contributor

@mamil mamil commented Nov 21, 2022

What type of PR is this?

test: Adding missing tests or correcting existing tests

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

为pkg/app/middlewares/server/basic_auth添加更多单元测试

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: Add BasicAuth related tests in pkg/app/middlewares/server/basic_auth, basic_auth.go reaches 100% coverage
zh(optional): 添加pkg/app/middlewares/server/basic_auth中BasicAuth相关的测试,basic_auth.go达到100%覆盖

Which issue(s) this PR fixes:

#257

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 67.53% // Head: 67.63% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (9f5b7df) compared to base (d601515).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #405      +/-   ##
===========================================
+ Coverage    67.53%   67.63%   +0.10%     
===========================================
  Files           89       89              
  Lines         8608     8608              
===========================================
+ Hits          5813     5822       +9     
+ Misses        2435     2426       -9     
  Partials       360      360              
Impacted Files Coverage Δ
pkg/common/compress/compress.go 80.95% <0.00%> (-2.86%) ⬇️
...kg/app/middlewares/server/basic_auth/basic_auth.go 100.00% <0.00%> (+54.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2022

CLA assistant check
All committers have signed the CLA.

@welkeyever
Copy link
Member

Please resign the CLA🙏

@mamil
Copy link
Contributor Author

mamil commented Nov 22, 2022

@welkeyever CLA signed

Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx~

@li-jin-gou li-jin-gou merged commit ec2ec49 into cloudwego:develop Nov 22, 2022
@mamil mamil deleted the add-auth-ut branch November 22, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants