refactor: open hz code for being called #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 67.29% // Head: 67.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #383 +/- ##
===========================================
+ Coverage 67.29% 67.34% +0.04%
===========================================
Files 89 89
Lines 8608 8608
===========================================
+ Hits 5793 5797 +4
+ Misses 2454 2450 -4
Partials 361 361
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
FGYFFFF
force-pushed
the
refactor/open_code
branch
3 times, most recently
from
042dfa5 to
0d8ce2c
Compare
|
Remove internal_pkg directly? |
Yes. Use the ".doc" file to declare that this package may not be backward compatible and should not be relied upon. kitex, protoc-gen-go all use a similar approach |
FGYFFFF
force-pushed
the
refactor/open_code
branch
from
0d8ce2c to
beb9b72
Compare
FGYFFFF
force-pushed
the
refactor/open_code
branch
from
beb9b72 to
277a738
Compare
welkeyever
approved these changes
Nov 18, 2022
li-jin-gou
approved these changes
Nov 18, 2022
Duslia
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
refactor
Check the PR title.
(Optional) Translate the PR title into Chinese.
开放 hz 的代码，以供调用
(Optional) More detail description for this PR(en: English/zh: Chinese).
en: remove package 'internal'
zh(optional): 去掉 'internal' package
Which issue(s) this PR fixes: