Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: listen localhost instead of all ip addr #382

Merged

Conversation

welkeyever
Copy link
Member

@welkeyever welkeyever commented Nov 17, 2022

What type of PR is this?

test

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

单测启动 server 只需要监听 localhost 地址,无需监听所有地址

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: listen all addr needs more permission in some platform, but it is unnecessary.
zh(optional): 监听所有地址在某些平台上需要更多权限,但这个并没有必要。

Which issue(s) this PR fixes:

@welkeyever welkeyever force-pushed the test/no_need_to_listen_all_ip_addr branch from cbc8135 to 0aae58a Compare November 17, 2022 09:59
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 67.29% // Head: 67.37% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (0aae58a) compared to base (d6b85fe).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #382      +/-   ##
===========================================
+ Coverage    67.29%   67.37%   +0.08%     
===========================================
  Files           89       89              
  Lines         8608     8608              
===========================================
+ Hits          5793     5800       +7     
+ Misses        2454     2447       -7     
  Partials       361      361              
Impacted Files Coverage Δ
pkg/common/compress/compress.go 83.80% <0.00%> (+2.85%) ⬆️
pkg/common/timer/timer.go 80.95% <0.00%> (+19.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@welkeyever welkeyever merged commit 3e131ae into cloudwego:develop Nov 18, 2022
@welkeyever welkeyever deleted the test/no_need_to_listen_all_ip_addr branch November 18, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants