Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve observability of hostclient #380

Merged
merged 1 commit into from
Dec 26, 2022

Conversation

Duslia
Copy link
Member

@Duslia Duslia commented Nov 17, 2022

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

提高 hostclient 的可观测性

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: Improve observability of hostclient. Add HostClientState interface and provide method to inject observation function. Launch a goroutine to call the observation function after creating HostClient
zh(optional): 提高 hostclient 的可观测性。增加 HostClientState 接口,并可注入观测函数。在创建 HostClient 后,启动协程调用观测函数

Which issue(s) this PR fixes:

@Duslia Duslia force-pushed the feat/client_observation_improve branch from 970145a to bf72ee8 Compare November 17, 2022 06:30
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 69.69% // Head: 69.54% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (5f086d0) compared to base (a7a3fc0).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #380      +/-   ##
===========================================
- Coverage    69.69%   69.54%   -0.15%     
===========================================
  Files           93       93              
  Lines         8760     8791      +31     
===========================================
+ Hits          6105     6114       +9     
- Misses        2293     2314      +21     
- Partials       362      363       +1     
Impacted Files Coverage Δ
pkg/common/config/client_option.go 100.00% <ø> (ø)
pkg/common/errors/errors.go 87.95% <ø> (ø)
pkg/protocol/http1/client.go 49.80% <6.66%> (-1.21%) ⬇️
pkg/app/client/option.go 96.66% <83.33%> (-3.34%) ⬇️
pkg/app/client/client.go 74.84% <100.00%> (+0.15%) ⬆️
pkg/common/timer/timer.go 61.90% <0.00%> (-19.05%) ⬇️
pkg/common/compress/compress.go 80.95% <0.00%> (-2.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Duslia Duslia force-pushed the feat/client_observation_improve branch 2 times, most recently from 442200e to c9aaee8 Compare November 17, 2022 06:43
@Duslia Duslia force-pushed the feat/client_observation_improve branch from c9aaee8 to 5707793 Compare November 17, 2022 09:39
@Duslia Duslia changed the title feat: improve observability of hostclient. feat: improve observability of hostclient Nov 17, 2022
li-jin-gou
li-jin-gou previously approved these changes Nov 21, 2022
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2022

CLA assistant check
All committers have signed the CLA.

@Duslia Duslia force-pushed the feat/client_observation_improve branch from 5707793 to 31e5ea4 Compare December 23, 2022 08:18
@Duslia Duslia requested review from a team as code owners December 23, 2022 08:18
@Duslia Duslia force-pushed the feat/client_observation_improve branch 5 times, most recently from 659679d to 743ce27 Compare December 23, 2022 10:42
@Duslia Duslia enabled auto-merge (squash) December 23, 2022 10:43
@Duslia Duslia force-pushed the feat/client_observation_improve branch 2 times, most recently from 553e415 to c53c203 Compare December 23, 2022 11:46
li-jin-gou
li-jin-gou previously approved these changes Dec 26, 2022
@Duslia Duslia merged commit b309811 into cloudwego:develop Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants