Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: empty slice and redundant type conversion and .gitignore add develop tools #348

Merged
merged 2 commits into from
Nov 8, 2022
Merged

style: empty slice and redundant type conversion and .gitignore add develop tools #348

merged 2 commits into from
Nov 8, 2022

Conversation

demoManito
Copy link
Contributor

@demoManito demoManito commented Nov 4, 2022

What type of PR is this?

style

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

修改代码风格:

(Optional) More detail description for this PR(en: English/zh: Chinese).

en:
zh(optional):

Which issue(s) this PR fixes:

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2022

CLA assistant check
All committers have signed the CLA.

…e add develop tools

Signed-off-by: demoManito <1430482733@qq.com>
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 66.18% // Head: 66.14% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (21cf865) compared to base (9774687).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #348      +/-   ##
===========================================
- Coverage    66.18%   66.14%   -0.05%     
===========================================
  Files           85       85              
  Lines         8319     8320       +1     
===========================================
- Hits          5506     5503       -3     
- Misses        2454     2458       +4     
  Partials       359      359              
Impacted Files Coverage Δ
pkg/route/tree.go 96.68% <100.00%> (+0.01%) ⬆️
pkg/common/timer/timer.go 61.90% <0.00%> (-19.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@welkeyever welkeyever changed the title style(hertz): empty slice and redundant type conversion and .gitignore add develop tools style: empty slice and redundant type conversion and .gitignore add develop tools Nov 8, 2022
@welkeyever welkeyever merged commit 430acd0 into cloudwego:develop Nov 8, 2022
@demoManito demoManito deleted the style/empty-slice branch November 8, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants