Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hz): fix the error of inserting to import for different os #327

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Oct 27, 2022

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

修复插入import时由于不同系统换行符带来的影响

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: fix the error of inserting to import for different os
zh(optional): 修复插入import时由于不同系统换行符带来的影响

Which issue(s) this PR fixes:

@FGYFFFF FGYFFFF force-pushed the fix/ast_for_import branch 2 times, most recently from b5490f3 to 43bf1cf Compare October 28, 2022 02:42
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 66.60% // Head: 66.17% // Decreases project coverage by -0.43% ⚠️

Coverage data is based on head (1e870bf) compared to base (201664a).
Patch has no changes to coverable lines.

❗ Current head 1e870bf differs from pull request most recent head cfaafd6. Consider uploading reports for the commit cfaafd6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #327      +/-   ##
===========================================
- Coverage    66.60%   66.17%   -0.44%     
===========================================
  Files           89       85       -4     
  Lines         8514     8319     -195     
===========================================
- Hits          5671     5505     -166     
+ Misses        2481     2455      -26     
+ Partials       362      359       -3     
Impacted Files Coverage Δ
pkg/protocol/http1/req/request.go 60.00% <0.00%> (-1.89%) ⬇️
pkg/route/engine.go 62.06% <0.00%> (-0.58%) ⬇️
pkg/route/tree.go 96.67% <0.00%> (-0.02%) ⬇️
pkg/app/server/option.go 96.63% <0.00%> (ø)
pkg/common/config/option.go 100.00% <0.00%> (ø)
pkg/app/middlewares/server/recovery/option.go 100.00% <0.00%> (ø)
pkg/common/hlog/log.go
pkg/common/hlog/default.go
pkg/common/hlog/system.go
pkg/common/hlog/hlog.go
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FGYFFFF FGYFFFF force-pushed the fix/ast_for_import branch 2 times, most recently from 1b13686 to 625c984 Compare October 28, 2022 09:19
welkeyever
welkeyever previously approved these changes Nov 11, 2022
li-jin-gou
li-jin-gou previously approved these changes Nov 11, 2022
@FGYFFFF FGYFFFF dismissed stale reviews from li-jin-gou and welkeyever via cfaafd6 November 11, 2022 08:18
@FGYFFFF FGYFFFF merged commit 3090994 into cloudwego:develop Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants