Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: modify the default log of the recovery middleware #322

Merged
merged 1 commit into from
Oct 28, 2022
Merged

optimize: modify the default log of the recovery middleware #322

merged 1 commit into from
Oct 28, 2022

Conversation

li-jin-gou
Copy link
Member

@li-jin-gou li-jin-gou commented Oct 24, 2022

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

修改 recovery 中间件的默认日志

Which issue(s) this PR fixes:

@li-jin-gou li-jin-gou changed the title optimize: modify recovery log format optimize: modify the default log of the recovery middleware Oct 24, 2022
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 64.52% // Head: 64.52% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (ab14981) compared to base (3a6bb4a).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head ab14981 differs from pull request most recent head a43d18b. Consider uploading reports for the commit a43d18b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #322      +/-   ##
===========================================
- Coverage    64.52%   64.52%   -0.01%     
===========================================
  Files           85       85              
  Lines         8319     8318       -1     
===========================================
- Hits          5368     5367       -1     
  Misses        2588     2588              
  Partials       363      363              
Impacted Files Coverage Δ
pkg/app/middlewares/server/recovery/option.go 100.00% <100.00%> (ø)
pkg/app/middlewares/server/recovery/recovery.go 79.54% <0.00%> (-6.82%) ⬇️
pkg/common/compress/compress.go 83.80% <0.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@welkeyever
Copy link
Member

应该还有个unused func一并移除了吧

@li-jin-gou li-jin-gou merged commit 19fc097 into cloudwego:develop Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants