-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: enrich ut for pkg/protocol/header.go #299
Conversation
defc75f
to
a21ec43
Compare
a21ec43
to
37220a9
Compare
Codecov ReportBase: 64.52% // Head: 66.17% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #299 +/- ##
===========================================
+ Coverage 64.52% 66.17% +1.64%
===========================================
Files 85 85
Lines 8319 8319
===========================================
+ Hits 5368 5505 +137
+ Misses 2588 2455 -133
+ Partials 363 359 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bc30e55
to
5e94d88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
提高对
hertz/pkg/protocol/header
的单测覆盖率(Optional) More detail description for this PR(en: English/zh: Chinese).
en:
hertz/pkg/protocol/header
ut coverage increased from 55.73% to 80.4%zh(optional):
hertz/pkg/protocol/header
的单测覆盖率从 55.73% 提升到了 80.4%Which issue(s) this PR fixes:
#257