Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enrich ut for pkg/protocol/header.go #299

Merged
merged 7 commits into from
Oct 26, 2022

Conversation

zstone12
Copy link
Contributor

@zstone12 zstone12 commented Oct 15, 2022

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

提高对 hertz/pkg/protocol/header 的单测覆盖率

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: hertz/pkg/protocol/header ut coverage increased from 55.73% to 80.4%
zh(optional): hertz/pkg/protocol/header 的单测覆盖率从 55.73% 提升到了 80.4%

Which issue(s) this PR fixes:

#257

@zstone12 zstone12 force-pushed the test/add_header_ut branch 2 times, most recently from defc75f to a21ec43 Compare October 15, 2022 08:49
@zstone12 zstone12 changed the title [WIP]test: enrich ut for pkg/protocol/header.go test: enrich ut for pkg/protocol/header.go Oct 15, 2022
pkg/protocol/header_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Base: 64.52% // Head: 66.17% // Increases project coverage by +1.64% 🎉

Coverage data is based on head (c1debde) compared to base (3a6bb4a).
Patch has no changes to coverable lines.

❗ Current head c1debde differs from pull request most recent head 31d1209. Consider uploading reports for the commit 31d1209 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #299      +/-   ##
===========================================
+ Coverage    64.52%   66.17%   +1.64%     
===========================================
  Files           85       85              
  Lines         8319     8319              
===========================================
+ Hits          5368     5505     +137     
+ Misses        2588     2455     -133     
+ Partials       363      359       -4     
Impacted Files Coverage Δ
pkg/common/compress/compress.go 83.80% <0.00%> (+2.85%) ⬆️
pkg/protocol/header.go 73.85% <0.00%> (+17.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zstone12 zstone12 changed the title test: enrich ut for pkg/protocol/header.go (WIP)test: enrich ut for pkg/protocol/header.go Oct 16, 2022
@zstone12 zstone12 changed the title (WIP)test: enrich ut for pkg/protocol/header.go test: enrich ut for pkg/protocol/header.go Oct 22, 2022
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@li-jin-gou li-jin-gou merged commit e0ac536 into cloudwego:develop Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants