Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render support IndentedJSON #289

Merged
merged 1 commit into from
Oct 20, 2022
Merged

feat: render support IndentedJSON #289

merged 1 commit into from
Oct 20, 2022

Conversation

li-jin-gou
Copy link
Member

@li-jin-gou li-jin-gou commented Oct 11, 2022

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

render 支持 IndentedJSON

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: add JSONP and IndentedJSON
zh: render 支持 IndentedJSON

Which issue(s) this PR fixes:

@welkeyever
Copy link
Member

PR中文翻译也补充下哈

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 61.57% // Head: 64.62% // Increases project coverage by +3.05% 🎉

Coverage data is based on head (ea3a5d8) compared to base (202fe6a).
Patch coverage: 64.63% of modified lines in pull request are covered.

❗ Current head ea3a5d8 differs from pull request most recent head da2d551. Consider uploading reports for the commit da2d551 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #289      +/-   ##
===========================================
+ Coverage    61.57%   64.62%   +3.05%     
===========================================
  Files           84       84              
  Lines         8288     8325      +37     
===========================================
+ Hits          5103     5380     +277     
+ Misses        2831     2583     -248     
- Partials       354      362       +8     
Impacted Files Coverage Δ
pkg/app/client/loadbalance/lbcache.go 79.45% <0.00%> (ø)
pkg/app/client/loadbalance/weight_random.go 88.09% <0.00%> (ø)
pkg/network/netpoll/transport.go 0.00% <0.00%> (ø)
pkg/network/standard/transport.go 0.00% <0.00%> (ø)
pkg/protocol/http1/client.go 35.86% <0.00%> (ø)
pkg/app/fs.go 68.65% <10.00%> (ø)
pkg/route/engine.go 62.06% <11.11%> (ø)
pkg/app/server/render/html.go 37.50% <77.77%> (ø)
pkg/app/server/hertz.go 75.00% <80.00%> (ø)
pkg/app/server/render/json.go 71.42% <93.10%> (+23.28%) ⬆️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/app/context.go Outdated Show resolved Hide resolved
@li-jin-gou li-jin-gou changed the title feat: render support JSONP and IndentedJSON feat: render support IndentedJSON Oct 11, 2022
@li-jin-gou li-jin-gou merged commit 90536d9 into cloudwego:develop Oct 20, 2022
FGYFFFF pushed a commit to FGYFFFF/hertz that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants