Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enrich unit tests for pkg/protocol/request.go #285

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

BaiZe1998
Copy link
Contributor

@BaiZe1998 BaiZe1998 commented Oct 5, 2022

What type of PR is this?

test

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

Translate the PR title into Chinese.

为补充 pkg/protocol/request.go 单测

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: ut coverage 51.31% -> 85.3%
zh: 单测覆盖率 51.31% -> 85.3%

Which issue(s) this PR fixes:

Part of #257

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 61.57% // Head: 63.09% // Increases project coverage by +1.52% 🎉

Coverage data is based on head (83de078) compared to base (b7ff4bb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #285      +/-   ##
===========================================
+ Coverage    61.57%   63.09%   +1.52%     
===========================================
  Files           84       84              
  Lines         8288     8288              
===========================================
+ Hits          5103     5229     +126     
+ Misses        2831     2701     -130     
- Partials       354      358       +4     
Impacted Files Coverage Δ
pkg/common/compress/compress.go 80.95% <0.00%> (-2.86%) ⬇️
pkg/protocol/uri.go 87.06% <0.00%> (+0.63%) ⬆️
pkg/protocol/header.go 56.33% <0.00%> (+0.65%) ⬆️
pkg/protocol/request.go 83.24% <0.00%> (+31.93%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx!

@welkeyever welkeyever changed the title ut: enrich unit tests for pkg/protocol/request.go test: enrich unit tests for pkg/protocol/request.go Oct 8, 2022
@welkeyever welkeyever merged commit 23aaeb7 into cloudwego:develop Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants