test: ut supplementary for pkg/network #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
li-jin-gou
changed the title
li-jin-gou
requested review from
welkeyever,
li-jin-gou,
Duslia and
FGYFFFF
已经在pr中描述了循环依赖出现的场景 |
CI没有通过,可以修复一下. |
BaiZe1998
force-pushed
the
ut_network
branch
2 times, most recently
from
7e54e85 to
03baf95
Compare
Codecov ReportBase: 59.27% // Head: 60.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #271 +/- ##
===========================================
+ Coverage 59.27% 60.30% +1.03%
===========================================
Files 79 84 +5
Lines 8150 8266 +116
===========================================
+ Hits 4831 4985 +154
+ Misses 2966 2928 -38
Partials 353 353
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
li-jin-gou
changed the title
已修复 |
FGYFFFF
reviewed
Sep 26, 2022
FGYFFFF
reviewed
Sep 26, 2022
test: ut supplementary for pkg/network
BaiZe1998
force-pushed
the
ut_network
branch
from
03baf95 to
88d6325
Compare
welkeyever
approved these changes
Sep 29, 2022
15 tasks
li-jin-gou
approved these changes
Sep 29, 2022
FGYFFFF
approved these changes
Sep 29, 2022
|
LGTM |
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
test
Check the PR title.
Translate the PR title into Chinese.
为
pkg/network补充单元测试More detail description for this PR(en: English/zh: Chinese).
en:
unit tests coverage improvement：
pkg/network/dialer：0% -> 100%pkg/network/netpoll：0% -> 33.8%pkg/network/standard：46.2% -> 75.2%ps. Unit tests for
pkg/network/standard/dialer.go,pkg/network/standard/transport.go,pkg/network/netpoll/dialer.go,pkg/network/netpoll/transport.goare not supplemented due to circular references. Comments with solutions welcome.zh:
单测覆盖率提升：
pkg/network/dialer：0% -> 100%pkg/network/netpoll：0% -> 33.8%pkg/network/standard：46.2% -> 75.2%ps. 由于循环引用导致
pkg/network/standard/dialer.go,pkg/network/standard/transport.go,pkg/network/netpoll/dialer.go,pkg/network/netpoll/transport.go的单测未能补充，如有建议欢迎评论。具体细节：由于上述文件分别位于
network/standard和network/netpoll包当中，在模拟构造网络请求的时候，使用到了route包的Engine，而route包import了network/standard和network/netpollWhich issue(s) this PR fixes: