Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: softlink the plugin to $GOPATH/bin #235

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Sep 8, 2022

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

将插件软链接到 $GOPATH/bin 下

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: softlink the plugin to $GOPATH/bin
zh(optional): 将插件软链接到 $GOPATH/bin 下

Which issue(s) this PR fixes:

@FGYFFFF
Copy link
Contributor Author

FGYFFFF commented Sep 8, 2022

Previously, it would softlink the protoc plugins to different locations depending on the installation location of protoc, resulting in a possible insufficient permissions problem

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Base: 59.19% // Head: 59.19% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (e76a78d) compared to base (8751608).
Patch has no changes to coverable lines.

❗ Current head e76a78d differs from pull request most recent head d1c1915. Consider uploading reports for the commit d1c1915 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #235      +/-   ##
===========================================
- Coverage    59.19%   59.19%   -0.01%     
===========================================
  Files           79       79              
  Lines         8105     8104       -1     
===========================================
- Hits          4798     4797       -1     
  Misses        2953     2953              
  Partials       354      354              
Impacted Files Coverage Δ
pkg/network/standard/buffer.go 81.08% <0.00%> (-0.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FGYFFFF FGYFFFF force-pushed the optimize/modify_plugin_path branch from 2660157 to d1c1915 Compare September 19, 2022 10:22
@Duslia Duslia merged commit 419a448 into cloudwego:develop Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants