Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hz): client query enum #1064

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Feb 6, 2024

What type of PR is this?

refactor

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

重构 client query 对于 enum 传递的配置形式

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: Refactoring the client query's configuration form for enum
zh(optional): 重构 client query 对于 enum 传递的配置形式

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners February 6, 2024 10:42
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.54%. Comparing base (b7cbc9d) to head (ad3f359).
Report is 2 commits behind head on develop.

❗ Current head ad3f359 differs from pull request most recent head 3bc1be6. Consider uploading reports for the commit 3bc1be6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1064      +/-   ##
===========================================
- Coverage    82.79%   82.54%   -0.26%     
===========================================
  Files           98       98              
  Lines        10032    10025       -7     
===========================================
- Hits          8306     8275      -31     
- Misses        1236     1254      +18     
- Partials       490      496       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FGYFFFF FGYFFFF merged commit 0285a34 into cloudwego:develop Apr 18, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants