Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize(hz): rm_tag has a lower priority than the annotation #1006

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Nov 21, 2023

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

让 rm_tag 的优先级低于 IDL 中的 api.XXX 注解

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: rm_tag has a lower priority than the annotation
zh(optional): 让 rm_tag 的优先级低于 IDL 中的 api.XXX 注解

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners November 21, 2023 13:25
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (171630c) 81.81% compared to head (d6d22de) 82.60%.
Report is 16 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1006      +/-   ##
===========================================
+ Coverage    81.81%   82.60%   +0.79%     
===========================================
  Files           98       98              
  Lines         9962     9974      +12     
===========================================
+ Hits          8150     8239      +89     
+ Misses        1319     1240      -79     
- Partials       493      495       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@welkeyever
Copy link
Member

”rm_tag 的优先级低于 IDL 中的 api.XXX 注解”
better to:
“让 rm_tag 的优先级低于 IDL 中的 api.XXX 注解”?

cmd/hz/app/app.go Outdated Show resolved Hide resolved
@FGYFFFF FGYFFFF merged commit 9f310b6 into cloudwego:develop Jan 3, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants