Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more AgentOption for react agent and a converter function t… #94

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shentongmartin
Copy link
Contributor

What type of PR is this?

  1. Add more AgentOption functions, deprecating and replacing the old WithComposeOptions
  2. Provide ConvertOptions function to convert agent options to compose options, making it easier to specify AgentOption for agent as sub graph.
  3. Provide DesignateNodePrependPath method to compose.Option to help with converting AgentOption to ComposeOption

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 160 files.

Valid Invalid Ignored Fixed
159 1 0 0
Click to see the invalid file list
  • flow/agent/react/options.go

Copy link

github-actions bot commented Mar 5, 2025

📊 Coverage Report:

File coverage threshold (20%) satisfied:	PASS
Package coverage threshold (30%) satisfied:	PASS
Total coverage threshold (83%) satisfied:	PASS
Total test coverage: 83.7% (3564/4260)

@@ -80,6 +80,24 @@ func (o Option) DesignateNodeWithPath(path ...*NodePath) Option {
return o
}

// DesignateNodePrependPath prepends the prefix to the path of the node(s) to which the option will be applied to.
// Useful when you already have an Option designated to a graph's node, and now you want to add this graph as a subgraph.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是啥意思,如果你已经给graph node设置了option,现在你想把graph作为子图,那不应该在父图传option吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

挪到 Internal 里面了

…o compose.Option

Change-Id: I3a069cd40b5fff9d701b35c4f1d383c303e2387f
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 165 files.

Valid Invalid Ignored Fixed
163 2 0 0
Click to see the invalid file list
  • internal/compose/option.go
  • internal/flow/agent/option.go

Change-Id: I4fe923cdf2fc8e44ee2e1c895ad93b75ba30b2e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants