sc-12505 add exclude-dirs option for directory walking command #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #12505: Add --exclude-dirs to directory walking command. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 87.66% 87.77% +0.10%
==========================================
Files 11 11
Lines 681 687 +6
==========================================
+ Hits 597 603 +6
Misses 84 84 ☔ View full report in Codecov by Sentry. |
| @@ -251,6 +256,13 @@ def walk_directories(config_dir, file_types, output_dir): | |||
| if dir in dirs: | |||
| dirs.remove(dir) | |||
|
|
|||
| # skip over user-specified non-config directories | |||
| for dir in exclude_dirs: | |||
There was a problem hiding this comment.
Does this still exclude your default list too?
There was a problem hiding this comment.
I left that loop above the new code. But you've given me a better idea of how to concatenate the two lists.
There was a problem hiding this comment.
Eh, nevermind. The logic for finding referenced directories is too different from the existing logic. It will end up getting refactored later.
mikestack-tuono
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.