-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change diff to use CFN change sets instead of comparing template dicts #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove invalidated diff tests - fixing aws provider tests - add aws provider test for my changes - linting fix
troyready
approved these changes
Sep 16, 2019
Has this been released? or any plan on releasing it |
phobologic
approved these changes
Feb 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this- thank you, merging!
deepmap-marcinr
pushed a commit
to deepmap/stacker
that referenced
this pull request
Feb 24, 2020
…ate dicts (cloudtools#744)" This reverts commit 106ddf3.
deepmap-marcinr
pushed a commit
to deepmap/stacker
that referenced
this pull request
Mar 25, 2020
…ate dicts (cloudtools#744)" This reverts commit 106ddf3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using CFN Change Sets will give a more accurate representation of what is being changed. Akin to
terraform plan
.Usage
Interactive
A summary of changes is displayed for each stack (the same as
stacker build
). The user is prompted about displaying the full changeset before moving on.Default
The full change set is displayed. This example also showcases a stack (stacker-fake-resource) that is consuming the output of a previous stack (stacker-tf-state) resulting in an inferred change.