Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks: keypair: add some features and rewrite tests #715

Merged
merged 2 commits into from
Mar 21, 2019

Conversation

danielkza
Copy link
Contributor

  • Add support for importing a local public key file
  • Add support for storing generated private keys in SSM parameter store
  • Refactor code to be more streamlined and separate interactive input
    from other work

This is currently based on #714 since the tests make heavy use of pytest fixtures.

@danielkza danielkza changed the title hooks: keypair: overhaul and rewrite tests hooks: keypair: add some features and rewrite tests Mar 19, 2019
- Add support for importing a local public key file
- Add support for storing generated private keys in SSM parameter store
- Refactor code to be more streamlined and separate interactive input
from other work
@danielkza danielkza force-pushed the overhaul-keypair-hook branch from e220337 to c0cb02d Compare March 20, 2019 04:29
Copy link
Member

@phobologic phobologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. One small comment. If you'd rather not make the change it's not a big deal - just let me know!

stacker/hooks/keypair.py Outdated Show resolved Hide resolved
@phobologic phobologic merged commit 97d5206 into cloudtools:master Mar 21, 2019
@danielkza danielkza deleted the overhaul-keypair-hook branch March 29, 2019 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants