Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.7 tests in Circle CI #711

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Add Python 3.7 tests in Circle CI #711

merged 1 commit into from
Mar 12, 2019

Conversation

danielkza
Copy link
Contributor

No description provided.

@danielkza
Copy link
Contributor Author

danielkza commented Mar 12, 2019 •
edited
Loading

The Python 3.7 tests are indeed broken, and can be fixed by updating boto3, which I did in #712. I can rebase this after that is merged.

@russellballestrini
Copy link
Member

Thanks, please rebase!

@danielkza
Copy link
Contributor Author

Rebased!

phobologic
phobologic approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@phobologic phobologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for the refactor.

@phobologic phobologic merged commit 1f1df37 into cloudtools:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phobologic phobologic phobologic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielkza @russellballestrini @phobologic