Add helper Makefile for more easier integration tests #597
Conversation
|
Looks like you have failing functional tests. |
| permissions: | ||
| ./stacker.yaml.sh | stacker build - | ||
|
|
||
| test: permissions |
There was a problem hiding this comment.
We already have a test-functional target in the top level Makefile. Maybe move this there? https://github.com/remind101/stacker/blob/master/Makefile#L13
There was a problem hiding this comment.
I saw that after I submitted this - do you think I should include the permissions step and use it as a dependency? @ejholmes
There was a problem hiding this comment.
Hey @ejholmes we talked about this in person, but I can't remember where we landed. The functional tests that we run in circle don't have permissions to make the permissions for themselves, and that was a security decision I'm pretty sure. Moving what I have here to the tests used in circle would cause it to break, unless you have another idea (or I'm not thinking about this correctly).
What are your thoughts?
These checks are flakey - and really don't provide a ton, since we see the final state.
|
I'm going to go ahead and merge this - we can figure out if we want to somehow merge this with the main Makefile tests later. One thing to keep in mind - this changes the way the tests are run now quite a bit, making it easier to run a single test. Please see the readme @ejholmes @russellballestrini |
* Add helper Makefile for more easier integration tests * no need for cd, -C is better * Make it possible to run a single test case * Add specific test examples * Fix functional tests for new functional test method * Remove check for updating rollback state These checks are flakey - and really don't provide a ton, since we see the final state.
No description provided.