Don't require class_path or template_path for locked stacks #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejholmes
force-pushed
the
locked-stacks
branch
2 times, most recently
from
8af833e to
35ca74d
Compare
phobologic
approved these changes
Mar 15, 2018
There was a problem hiding this comment.
Minor question: What happens if someone has a locked stack config but the stack doesn't already exist? This is likely something we handle already - my guess is that locked only blocks updates, not creates. Otherwise this looks fine - can you add something to the docs of the locked config?
|
Good call. I updated the functional test to test for that scenario as well. I'll merge this once CI is passing. |
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
Don't require class_path or template_path for locked stacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, "locked" stacks don't actually need a
class_pathor atemplate_path, since they're readonly. This change also fixes a bug introduced in #550, where theoutputplugin would fail with the following when looking up outputs on locked stacks:Tests are gonna fail right now until #556 is merged.