-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified logging #532
Simplified logging #532
Conversation
cc19e24
to
0ae98dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #532 +/- ##
==========================================
- Coverage 88.6% 87.94% -0.66%
==========================================
Files 94 91 -3
Lines 5987 5875 -112
==========================================
- Hits 5305 5167 -138
- Misses 682 708 +26
Continue to review full report at Codecov.
|
Wow, this is refreshing, nice work! |
0ae98dc
to
b418d5e
Compare
log_level = logging.INFO | ||
log_format = INFO_FORMAT | ||
if sys.stdout.isatty(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this, thanks.
Ok, pushed a small update. @ejholmes can you take a look at why the test_util.py tests are all super noisy in tests now? See: https://circleci.com/gh/remind101/stacker/1404?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link (I thought it was something I had done, but it looks like it's been happening since this update) |
6ee3ae4
to
1727ce0
Compare
Tests were noisy because the root logger in tests was being switched out with a StreamLogger in I added a commit to this that dependency injects the |
97db788
to
1a81dd4
Compare
Simplified logging
Closes #527
This removes the "loop logger", and replaces it with a simple sequential logger. I think this solves all of the problems talked about in #527:
--interactive
.Here's an example of what the output looks like: