Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove required_stacks tag #110

Merged
merged 1 commit into from
Oct 13, 2015
Merged

Remove required_stacks tag #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions stacker/actions/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,17 +81,11 @@ def _resolve_parameters(self, parameters, blueprint):
params[k] = value
return params

def _build_stack_tags(self, stack, template_url):
def _build_stack_tags(self, stack):
"""Builds a common set of tags to attach to a stack"""
requires = [req for req in stack.requires]
logger.debug("Stack %s required stacks: %s",
stack.name, requires)
tags = {
'template_url': template_url,
'stacker_namespace': self.context.namespace,
}
if requires:
tags['required_stacks'] = ':'.join(requires)
return tags

def _launch_stack(self, stack, **kwargs):
Expand Down Expand Up @@ -120,7 +114,7 @@ def _launch_stack(self, stack, **kwargs):

logger.info("Launching stack %s now.", stack.fqn)
template_url = self.s3_stack_push(stack.blueprint)
tags = self._build_stack_tags(stack, template_url)
tags = self._build_stack_tags(stack)
parameters = self._resolve_parameters(stack.parameters,
stack.blueprint)
required_params = [k for k, v in stack.blueprint.required_parameters]
Expand Down
6 changes: 0 additions & 6 deletions stacker/providers/aws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,6 @@ def update_stack(self, fqn, template_url, parameters, tags, **kwargs):
raise
return True

def get_required_stacks(self, stack, **kwargs):
required_stacks = []
if 'required_stacks' in stack.tags:
required_stacks = stack.tags['required_stacks']
return required_stacks

def get_stack_name(self, stack, **kwargs):
return stack.stack_name

Expand Down