-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace spansql #84
Replace spansql #84
Conversation
hmm, this seems a similar implementation in spansql package. This is another kind of parser I think so it's not good to have the implementation inside each OSS. |
It is not a Cloud Spanner client library so I don't think it can be merged into https://github.com/googleapis/google-cloud-go. IMHO, it can be maintained as a standalone repo in cloudspannerecosystem. Note: |
It might be possible to describe it as a helper function for using UpdateDDL and Batch DML. |
It seems most of the recent changes to spansql are not related to spannertest. |
I think there is a difference between that and this case because The last update by Googler seems to be over a year old. |
I would like to correct one factual error. (Added) Originally, |
I have implemented customizable separator for demonstrating purpose. |
After internal discussion, this PR was closed as it has no chance of being approved unless there is a place to maintain the statement separator. |
WHAT
Replace spansql with statement separator which is derived from spanner-cli implementation.
WHY
#83
TODO