Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing animations to discreet split panel (2) #3339

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jperals
Copy link
Member

@jperals jperals commented Mar 7, 2025

Description

Recreation of #3322 with a fix for the closed discreet split panel displaying a double shadow in Classic.

Ticket: AWSUI-60450

How has this been tested?

In my pipeline

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (c4a43a9) to head (b9c3116).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3339   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files         791      791           
  Lines       22611    22616    +5     
  Branches     7814     7811    -3     
=======================================
+ Hits        21803    21808    +5     
- Misses        754      801   +47     
+ Partials       54        7   -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jperals jperals force-pushed the fix/split-panel-classic-shadow branch from 29edc19 to 8c774cd Compare March 7, 2025 19:10
@jperals jperals changed the title fix: Remove undesired extra shadow to discreet split panel in Classic fix: Add missing animations to discreet split panel Mar 7, 2025
@jperals jperals force-pushed the fix/split-panel-classic-shadow branch from 8c774cd to d204c64 Compare March 7, 2025 21:33
@jperals jperals changed the title fix: Add missing animations to discreet split panel fix: Add missing animations to discreet split panel (2) Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant