Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add internal drag handle UAP support #3311

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

avinashbot
Copy link
Member

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 76.53631% with 42 lines in your changes missing coverage. Please review.

Project coverage is 96.26%. Comparing base (22d7bca) to head (4efeecf).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
.../internal/components/drag-handle-wrapper/index.tsx 71.76% 24 Missing ⚠️
src/code-editor/resizable-box/index.tsx 39.28% 17 Missing ⚠️
...omponents/drag-handle-wrapper/direction-button.tsx 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3311      +/-   ##
==========================================
- Coverage   96.42%   96.26%   -0.16%     
==========================================
  Files         791      795       +4     
  Lines       22603    22768     +165     
  Branches     7814     7866      +52     
==========================================
+ Hits        21795    21918     +123     
- Misses        754      843      +89     
+ Partials       54        7      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant