Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes test runs from release workflows #2908

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Oct 21, 2024

Description

Skipping all tests for release job as unnecessary: for main branch the tests are already run as part of the PR actions and for dev branches that technically allows a change with failing tests propagate to the dev. environment which is ok.

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (01aecc9) to head (85e0abb).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2908    +/-   ##
========================================
  Coverage   96.21%   96.21%            
========================================
  Files         761      761            
  Lines       21530    21530            
  Branches     7308     6971   -337     
========================================
  Hits        20715    20715            
- Misses        762      807    +45     
+ Partials       53        8    -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot pan-kot marked this pull request as ready for review October 22, 2024 11:13
@pan-kot pan-kot requested a review from a team as a code owner October 22, 2024 11:13
@pan-kot pan-kot requested review from jperals and removed request for a team October 22, 2024 11:13
@pan-kot pan-kot added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 62bfa2f Oct 22, 2024
40 checks passed
@pan-kot pan-kot deleted the release-workflow-no-tests branch October 22, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants