feat: Updated query macro autoscale_or_ondemand #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to the bag here - |
2 tasks
jsonpr
approved these changes
Nov 13, 2023
| t.arn AS resource_id, | ||
| CASE | ||
| WHEN t.billing_mode_summary:BillingMode = 'PAY_PER_REQUEST' then 'pass' | ||
| WHEN (t.billing_mode_summary:BillingMode = 'PROVISIONED' or t.billing_mode_summary:BillingMode is NULL )and (pr._cq_id IS not NULL and pw._cq_id IS not NULL) then 'pass' |
There was a problem hiding this comment.
I think we could streamline the logic here from below, but this is fine for now. This checks if the table has both Read and Write autoscaling enabled (and Provisioned).
ronsh12
force-pushed
the
private/ron/dynamodb_1
branch
from
811adb3 to
bbca2a7
Compare
This was referenced Nov 16, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
🤖 I have created a release *beep* *boop* --- ## [0.1.0](transformation-aws-compliance-free-v0.0.1...transformation-aws-compliance-free-v0.1.0) (2023-11-17) ### Features * Add All Queries from AWS Plugin ([#166](#166)) ([b9f2782](b9f2782)) * DBT tests ([#159](#159)) ([9544114](9544114)) * Reorder things and move to cross platform queries ([#160](#160)) ([2e9e699](2e9e699)) * Updated query instances_should_have_association_compliance_stat… ([#175](#175)) ([41a0a6c](41a0a6c)) * Updated query macro autoscale_or_ondemand ([#178](#178)) ([8cbf273](8cbf273)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
🤖 I have created a release *beep* *boop* --- ## 0.0.1 (2023-11-20) ### Features * Add All Queries from AWS Plugin ([#166](#166)) ([b9f2782](b9f2782)) * DBT tests ([#159](#159)) ([9544114](9544114)) * Updated query instances_should_have_association_compliance_stat… ([#175](#175)) ([41a0a6c](41a0a6c)) * Updated query macro autoscale_or_ondemand ([#178](#178)) ([8cbf273](8cbf273)) ### Miscellaneous Chores * release 0.0.1 ([2e9e699](2e9e699)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.