Add documentaton for "key" property #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
added
documentation
nitrocode
reviewed
Nov 14, 2024
| @@ -34,6 +34,8 @@ variable "records" { | |||
| proxied: | |||
| Whether the record gets Cloudflare's origin protection. | |||
| Default value: false. | |||
| key: | |||
There was a problem hiding this comment.
The markdown documentation would need to be updated to showcase this change
There was a problem hiding this comment.
seems to me documentation generation was already outdated:
There was a problem hiding this comment.
i'll rebase after #54 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Document using "key":
terraform-cloudflare-zone/main.tf
Line 11 in c464ebf
why
Default terraform resource name is based on value. I wouldn't want that for CNAMEs. The workaround is to specify fixed
keyfor those records.references