Allow Records with Matching Name + Type #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
…orm-cloudflare-zone into matching_named_records
|
/test all |
nitrocode
reviewed
Oct 13, 2022
| record.name, | ||
| record.type, | ||
| index(local.flatten_records, record) |
There was a problem hiding this comment.
It's probably obvious but could you explain what the value of the index function would return as an example of a record input to this module?
nitrocode
requested changes
Oct 13, 2022
There was a problem hiding this comment.
Thank you for putting in this PR.
@Nuru and I spoke of this change not too long ago and we decided that a key input would be the best path forward.
A few days ago we received this PR which does have the key input. It's worth reviewing that one instead of this one.
https://github.com/cloudposse/terraform-cloudflare-zone/pull/17/files
|
Closing in favor of #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references
recordsinterface to allow for multiple records with unique values #15recordsshould default to an empty list instead ofnull#14