Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add ipset support #50

Merged
merged 16 commits into from
Aug 17, 2023
Merged

Feature/add ipset support #50

merged 16 commits into from
Aug 17, 2023

Conversation

Sytten
Copy link
Contributor

@Sytten Sytten commented Aug 17, 2023

what

  • Add ip_set variable in ip_set_reference_statement_rules to create IP Set automatically

why

  • If the IP set is not shared, there is no need to have separate from the WAF module
  • It allows a user of atmos to continue defining all their rules in yaml, otherwise they have to use tf code to forward the ARN to this module

@Sytten Sytten requested review from a team as code owners August 17, 2023 19:47
@Sytten Sytten requested review from Gowiem and korenyoni August 17, 2023 19:47
@Sytten Sytten mentioned this pull request Aug 17, 2023
Closed
@Sytten
Copy link
Contributor Author

Sytten commented Aug 17, 2023

@aknysh Readme is generated

@aknysh
Copy link
Member

aknysh commented Aug 17, 2023

/terratest

@aknysh
Copy link
Member

aknysh commented Aug 17, 2023

@Sytten thanks again, please review this error https://github.com/cloudposse/actions/actions/runs/5895367134/job/15990997080

@Sytten
Copy link
Contributor Author

Sytten commented Aug 17, 2023 •
edited
Loading

Should be fixed @aknysh

@aknysh
Copy link
Member

aknysh commented Aug 17, 2023

/terratest

aknysh
aknysh approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Sytten

@aknysh aknysh merged commit 330f9f1 into cloudposse:main Aug 17, 2023
@Sytten
Copy link
Contributor Author

Sytten commented Aug 18, 2023

Thanks for the fast review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sytten @aknysh