Stop replacing single_header & single_query_argument with an int #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
jamengual
approved these changes
Feb 7, 2023
jamengual
approved these changes
Feb 7, 2023
aknysh
reviewed
Feb 7, 2023
| @@ -753,15 +753,15 @@ resource "aws_wafv2_web_acl" "default" { | |||
| } | |||
|
|
|||
| dynamic "single_header" { | |||
| for_each = lookup(field_to_match.value, "single_header", null) != null ? [1] : [] | |||
| for_each = lookup(field_to_match.value, "single_header", null) != null ? [field_to_match.value.single_header] : [] | |||
|
|
|||
| content { | |||
| name = single_header.value.name | |||
There was a problem hiding this comment.
this could be fixed w/o changing the for_each but instead using
name = field_to_match.value.single_header.value.name
There was a problem hiding this comment.
But wouldn't that be very confusing given all the other use of for_each in the file?
E.g.
https://github.com/cloudposse/terraform-aws-waf/blob/master/rules.tf#L499
https://github.com/cloudposse/terraform-aws-waf/blob/master/rules.tf#L463
https://github.com/cloudposse/terraform-aws-waf/blob/master/rules.tf#L248
https://github.com/cloudposse/terraform-aws-waf/blob/master/rules.tf#L145
etc.
There was a problem hiding this comment.
I think this for_each does not follow the pattern that @paulerickson is referring too and the change proposed will make it more consistant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
1, resulting in an error when trying to access itsnameattributewhy
single_headerandsingle_query_argumentare unusable without anameattributereferences