Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial implementation #1

Merged
merged 7 commits into from
Apr 10, 2021
Merged

feat: initial implementation #1

merged 7 commits into from
Apr 10, 2021

Conversation

SweetOps
Copy link
Contributor

what

  • initial implementation of module

references

  • BUTTERFLY-289

@SweetOps SweetOps marked this pull request as draft March 29, 2021 19:18
@SweetOps SweetOps marked this pull request as ready for review March 31, 2021 14:03
@SweetOps
Copy link
Contributor Author

/test all

@SweetOps SweetOps assigned aknysh and osterman and unassigned osterman and aknysh Mar 31, 2021
@SweetOps SweetOps requested review from aknysh and osterman March 31, 2021 14:08
osterman
osterman reviewed Mar 31, 2021
View reviewed changes
README.yaml Outdated Show resolved Hide resolved
osterman
osterman previously approved these changes Mar 31, 2021
View reviewed changes
aknysh
aknysh reviewed Mar 31, 2021
View reviewed changes
variables.tf Show resolved Hide resolved
aknysh
aknysh reviewed Mar 31, 2021
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Mar 31, 2021
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Mar 31, 2021
View reviewed changes
rules.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Mar 31, 2021
View reviewed changes
rules.tf Show resolved Hide resolved
aknysh
aknysh reviewed Mar 31, 2021
View reviewed changes
rules.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Mar 31, 2021
View reviewed changes
main.tf Show resolved Hide resolved
aknysh
aknysh reviewed Mar 31, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SweetOps , that's a lot of code, and it LGTM, just a few minor comments

@SweetOps SweetOps requested review from a team as code owners April 1, 2021 11:58
@SweetOps
Copy link
Contributor Author

SweetOps commented Apr 1, 2021

/test all

@deadlysyn
Copy link

came here seeing if support existed in alb module, and if not ready to PR...then found this. awesome mind reading. looking forward to seeing it evolve.

@SweetOps SweetOps requested a review from a team as a code owner April 10, 2021 06:54
@Nuru
Copy link

Nuru commented Apr 10, 2021

/test all

@Nuru
Copy link

Nuru commented Apr 10, 2021

/test all

Nuru
Nuru approved these changes Apr 10, 2021
View reviewed changes
Copy link

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as beta release. It is just too complex to eyeball thoroughly.

@Nuru Nuru merged commit c4c8e10 into master Apr 10, 2021
@Nuru Nuru deleted the BUTTERFLY-289 branch April 10, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh left review comments

@Nuru Nuru Nuru approved these changes

@osterman osterman osterman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SweetOps @deadlysyn @Nuru @osterman @aknysh