Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds EIP provisioning #7

Merged
merged 10 commits into from
Aug 4, 2021
Merged

Adds EIP provisioning #7

merged 10 commits into from
Aug 4, 2021

Conversation

bradj
Copy link
Contributor

@bradj bradj commented Aug 3, 2021

what

  • This module should be able to provision an EIP on the users behalf

why

  • Forcing module users to account for simple infrastructure decisions isn't ideal

references

@bradj bradj requested review from a team as code owners August 3, 2021 22:04
@bradj bradj requested a review from a team as a code owner August 3, 2021 22:05
nitrocode
nitrocode reviewed Aug 3, 2021
View reviewed changes
main.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Aug 3, 2021
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Aug 3, 2021
View reviewed changes
outputs.tf Outdated Show resolved Hide resolved
bradj and others added 3 commits August 3, 2021 18:20
@bradj @nitrocode
Update variables.tf
49beb6e 
Co-authored-by: nitrocode <nitrocode@users.noreply.github.com>
@bradj @nitrocode
Update outputs.tf
8ab9fb3 
Co-authored-by: nitrocode <nitrocode@users.noreply.github.com>
@cloudpossebot
Auto Format
b7b7c39
nitrocode
nitrocode reviewed Aug 4, 2021
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Aug 4, 2021
View reviewed changes
main.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Aug 4, 2021
View reviewed changes
main.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Aug 4, 2021
View reviewed changes
examples/vpc/main.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode previously approved these changes Aug 4, 2021
View reviewed changes
@nitrocode nitrocode added the patch A minor, backward compatible change label Aug 4, 2021
@nitrocode nitrocode merged commit b1f86ce into master Aug 4, 2021
@nitrocode nitrocode deleted the feat/self-provision-eip branch August 4, 2021 03:09
@nitrocode nitrocode removed the patch A minor, backward compatible change label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bradj @nitrocode @cloudpossebot