Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add list with an empty string, necessary for terraform 0.12 destroy #52

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

schollii
Copy link
Contributor

what

Add the missing empty string list to coalesce() call

I have not tested whether this breaks terraform 0.11 destroy, but based on what I read it should not.

why

references

See eg 
- hashicorp/terraform#21370
- terraform-aws-modules/terraform-aws-ec2-instance#104

I have not tested whether this breaks terraform 0.11 destroy, but based on what I read it should not.
@schollii schollii requested a review from a team as a code owner June 25, 2020 02:02
@Gowiem
Copy link
Member

Gowiem commented Jun 25, 2020

/test all

Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schollii Huh, I believe I've run into this issue before, but did not know it was a recurring problem within HCL... interesting. Have you found a Terraform issue that calls this out? Seems like it should be dealt with upstream, though I get why we'd want to fix it here.

Anyway, approved!

@Gowiem Gowiem merged commit abb5af7 into cloudposse:master Jun 25, 2020
@Gowiem
Copy link
Member

Gowiem commented Jun 25, 2020

@schollii Thanks for the contribution! Released as 0.18.2.

Also, saw the issue you linked -- bummer that got closed... should resurface that issue with the Terraform team so this isn't needed. They should fix it, I'm sure it wouldn't be a big fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants