Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate IAM Group name from a context by default #41

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

max-lobur
Copy link
Contributor

@max-lobur max-lobur commented Aug 17, 2021

what

  • Calculate IAM Group name from a context by default

why

  • Hardcoded name causes collision on multi-region deployments

references

NOTE: this is a breaking change, I checked, the IAM group name can be updated in place, user binding too, but policy:

module.ses.aws_iam_group_policy.ses_group_policy[0] must be replaced

When you deploy this in a production environment it will cause a short IAM policy loss, which might cause some ongoing operations to fail. To avoid this blink, explicitly override the name to the previous value:

ses_group_name = "SESSenders"

@max-lobur max-lobur requested review from a team as code owners August 17, 2021 14:54
@max-lobur max-lobur requested review from bradj and dylanbannon August 17, 2021 14:54
@nitrocode
Copy link
Member

/test all

@max-lobur max-lobur merged commit 393cea8 into cloudposse:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants