feat: add timeouts to the instance resource + timeouts variable
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
Gowiem
approved these changes
Nov 10, 2022
Gowiem
changed the title
timeouts to the instance resource + timeouts variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
var.timeouts.xvariable with default values to theaws_db_instanceresource in main.tfwhy
I ran into an issue where using the module in TF Cloud during creation the run times out.
The instance get's created but due to the run timing out the TF Cloud state does not get updated and each subsequent run would tear down an instance and recreate it, timing out once again.
I added a timeouts variable with default terraform values, which a user can change if they desire in order to accommodate a longer run.