Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AWS version requirements #144

Merged
merged 4 commits into from
Oct 11, 2022
Merged

Update AWS version requirements #144

merged 4 commits into from
Oct 11, 2022

Conversation

cloudpossebot
Copy link
Member

@cloudpossebot cloudpossebot commented Aug 18, 2022 •
edited by Nuru
Loading

what

  • Update AWS provider version requirement 3.0 -> 4.9.0
  • Update Terraform requirement 0.13.0 -> 1.0.0

why

  • PR fix 'Warning: Argument is deprecated' db_name #140 made a change that requires AWS provider v4.0, and versions of 4.x prior to 4.9.0 have major incompatibilities with managing S3 and Security Group resources.
  • Cloud Posse policy of dropping support for pre-release Terraform versions.

references

@cloudpossebot cloudpossebot requested review from a team as code owners August 18, 2022 04:27
@cloudpossebot cloudpossebot added auto-update This PR was automatically generated no-release Do not create a new release (wait for additional code changes) labels Aug 18, 2022
@cloudpossebot cloudpossebot added the readme Improvements or additions to the README label Aug 18, 2022
@Nuru Nuru changed the title Update README.md and docs Update AWS version requirements Oct 11, 2022
@Nuru Nuru added minor New features that do not break anything and removed no-release Do not create a new release (wait for additional code changes) labels Oct 11, 2022
@Nuru Nuru enabled auto-merge (squash) October 11, 2022 20:58
@Nuru Nuru merged commit 28a0ca5 into master Oct 11, 2022
@Nuru Nuru deleted the auto-update/readme branch October 11, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem was automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
auto-update This PR was automatically generated minor New features that do not break anything readme Improvements or additions to the README
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

db_name field doesn't work for AWS Custom SQL Server databases
2 participants
@cloudpossebot @Nuru