Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timezone variable for mssql #141

Merged
merged 9 commits into from
Jun 17, 2022
Merged

Add timezone variable for mssql #141

merged 9 commits into from
Jun 17, 2022

Conversation

mbroers
Copy link
Contributor

@mbroers mbroers commented Jun 15, 2022

what

  • Adding the ability to specify timezone for MSSQL RDS instances

why

  • This variable is available to the terraform resource type so it should be available to the component
  • Legacy databases and applications may not handle date conversion and offset properly and by default RDS sets timezone to UTC

references

@mbroers mbroers requested review from a team as code owners June 15, 2022 21:34
@mbroers mbroers requested review from Makeshift and milldr June 15, 2022 21:34
bridgecrew[bot]
bridgecrew bot reviewed Jun 15, 2022
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found infrastructure configuration errors in this PR ⬇️

main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Jun 15, 2022
View reviewed changes
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Jun 15, 2022
View reviewed changes
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Jun 15, 2022
View reviewed changes
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Jun 15, 2022
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to b661391 - Auto Format - 3 errors were fixed.

Change details

Error ID Change Path Resource
BC_AWS_LOGGING_28 Fixed /main.tf module.rds_instance.aws_db_instance.default
BC_AWS_GENERAL_46 Fixed /main.tf module.rds_instance.aws_db_instance.default
BC_AWS_IAM_60 Fixed /main.tf module.rds_instance.aws_db_instance.default

nitrocode
nitrocode reviewed Jun 17, 2022
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
mbroers and others added 2 commits June 17, 2022 08:31
@mbroers @nitrocode
Update variables.tf
4302481 
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@cloudpossebot
Auto Format
8d8f1a6
@nitrocode
Copy link
Member

/test all

nitrocode
nitrocode previously approved these changes Jun 17, 2022
View reviewed changes
@nitrocode
Copy link
Member

/test all

nitrocode
nitrocode previously approved these changes Jun 17, 2022
View reviewed changes
@nitrocode nitrocode changed the title adding timezone variable for mssql Add timezone variable for mssql Jun 17, 2022
@nitrocode
Copy link
Member

/test all

@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode merged commit 6c9b485 into cloudposse:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridgecrew Bridgecrew Bridgecrew left review comments

@nitrocode nitrocode nitrocode approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift Makeshift was automatically assigned from cloudposse/contributors

@milldr milldr Awaiting requested review from milldr milldr was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbroers @nitrocode @cloudpossebot