Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max instance lifetime #75

Merged
merged 5 commits into from
Jul 11, 2022
Merged

Max instance lifetime #75

merged 5 commits into from
Jul 11, 2022

Conversation

nitrocode
Copy link
Member

what

  • add max_instance_lifetime

why

From #70

Having this would be helpful as a backstop for the in-cluster node replacement options with cluster-autoscaler / node-problem-detector / Draino to ensure that a node is replaced even if all else fails.

references

@nitrocode nitrocode requested review from a team as code owners June 23, 2021 03:50
@nitrocode
Copy link
Member Author

/test all

@Nuru
Copy link
Contributor

Nuru commented Jun 26, 2021

/test all

@Nuru
Copy link
Contributor

Nuru commented Jun 26, 2021

/test all
Previous test failed due to problem with test workflow

@Nuru Nuru added the enhancement New feature or request label Jun 26, 2021
@Nuru Nuru added the no-release Do not create a new release (wait for additional code changes) label Jul 11, 2022
@Nuru Nuru merged commit af09fac into master Jul 11, 2022
@Nuru Nuru deleted the max_instance_lifetime branch July 11, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees
No one assigned
Labels
enhancement New feature or request no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose option for max_instance_lifetime
3 participants
@nitrocode @Nuru @cloudpossebot