Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform 0.14 upgrade #52

Merged
merged 8 commits into from
Feb 1, 2021
Merged

Terraform 0.14 upgrade #52

merged 8 commits into from
Feb 1, 2021

Conversation

maximmi
Copy link
Contributor

@maximmi maximmi commented Jan 5, 2021 •
edited
Loading

what

  • Upgrade to support Terraform 0.14 and bring up to current Cloud Posse standard

why

  • Support Terraform 0.14

supersedes and closes #48
supersedes and closes #37
supersedes and closes #33

@maximmi maximmi requested review from a team as code owners January 5, 2021 16:14
@maximmi maximmi requested review from Makeshift and nitrocode January 5, 2021 16:14
@maximmi maximmi self-assigned this Jan 5, 2021
@dotCipher
Copy link
Contributor

/test all

dotCipher
dotCipher previously approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@dotCipher dotCipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcalhoun
mcalhoun previously requested changes Jan 6, 2021
View reviewed changes
Copy link
Member

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change

.github/workflows/auto-context.yml Outdated Show resolved Hide resolved
@maximmi
Copy link
Contributor Author

maximmi commented Jan 7, 2021

/test all

@maximmi maximmi requested a review from mcalhoun January 7, 2021 11:12
@mergify mergify bot dismissed mcalhoun’s stale review January 7, 2021 11:12

This Pull Request has been updated, so we're dismissing all reviews.

Nuru
Nuru previously requested changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to current workflows

mcalhoun
mcalhoun previously approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nuru Nuru dismissed mcalhoun’s stale review January 20, 2021 18:32

Missed that workflows are out of date

@mergify mergify bot dismissed Nuru’s stale review January 27, 2021 18:03

This Pull Request has been updated, so we're dismissing all reviews.

@maximmi maximmi requested a review from a team as a code owner January 27, 2021 18:04
@maximmi
Copy link
Contributor Author

maximmi commented Jan 28, 2021

/test all

2 similar comments
@maximmi
Copy link
Contributor Author

maximmi commented Jan 28, 2021

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Jan 28, 2021

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Jan 28, 2021

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Jan 28, 2021

/rebuild-readme

@maximmi
Copy link
Contributor Author

maximmi commented Jan 28, 2021

/test all

@maximmi maximmi merged commit 54cffae into master Feb 1, 2021
@maximmi maximmi deleted the terraform-0.14-upgrade branch February 1, 2021 15:18
@martinhaus martinhaus mentioned this pull request Apr 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotCipher dotCipher dotCipher left review comments

@osterman osterman osterman approved these changes

@Nuru Nuru Nuru left review comments

@mcalhoun mcalhoun mcalhoun left review comments

@Makeshift Makeshift Awaiting requested review from Makeshift

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees

@maximmi maximmi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maximmi @dotCipher @osterman @mcalhoun @Nuru @actions-bot