Ignore the desired size when autoscaled #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since it's not possible to make the lifecycle dynamic and conditionally ignore changes based on the autoscaling configuration, manage differnent node group resources tailored for the different use cases BREAKING CHANGE: If already enabled the cluster autoscaler, the node group resources will be replaced, since the default node group is no longer the one with the autoscaling enabled fix cloudposse#12
|
Closing this in favor of #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
Ignore the desired size when the node group's autoscaling group is autoscaled externally (i.e. via the Kubernetes cluster autoscaler).
what
Since it's not possible to make the lifecycle dynamic and conditionally ignore changes based on the
autoscaling configuration, manage differnent node group resources tailored for the different use
cases.
references
BREAKING CHANGE
If already enabled the cluster autoscaler, the node group resources will be
replaced, since the default node group is no longer the one with the autoscaling enabled.