Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codestar source output artifact type var #97

Merged
merged 6 commits into from
Jul 20, 2022
Merged

Codestar source output artifact type var #97

merged 6 commits into from
Jul 20, 2022

Conversation

joe-niland
Copy link
Member

what

  • Allow specifying the output artifact format for the source stage of the Codestar pipeline
  • Small optimisation for checking when to create Codestar related resources
  • Assign Codestar policy to Codebuild service role if artifact format is 'full clone', as it is required for Codebuild to pull from the git repo

why

  • To allow flexibility
  • Previously the artifact format was hard-coded to 'CODE_ZIP'. Occasionally this fails with Bitbucket (due to some kind of internal error)

references

  • N/A

@joe-niland joe-niland requested review from a team as code owners July 13, 2022 12:02
@joe-niland joe-niland requested review from adamcrews and milldr July 13, 2022 12:02
@joe-niland joe-niland mentioned this pull request Jul 13, 2022
Closed
@joe-niland
Copy link
Member Author

/test all

nitrocode
nitrocode reviewed Jul 14, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jul 14, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jul 14, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jul 14, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jul 14, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jul 14, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jul 14, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jul 14, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jul 14, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@joe-niland
Copy link
Member Author

/test all

@joe-niland joe-niland requested review from aknysh and nitrocode July 14, 2022 22:11
@nitrocode nitrocode merged commit 8c7f266 into cloudposse:master Jul 20, 2022
@joe-niland joe-niland deleted the codestar-source-output-artifact-type-var branch July 31, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@adamcrews adamcrews Awaiting requested review from adamcrews adamcrews was automatically assigned from cloudposse/contributors

@milldr milldr Awaiting requested review from milldr milldr was automatically assigned from cloudposse/contributors

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joe-niland @aknysh @nitrocode @cloudpossebot