Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add name output #2

Merged
merged 5 commits into from
Mar 8, 2018
Merged

add name output #2

merged 5 commits into from
Mar 8, 2018

Conversation

osterman
Copy link
Member

@osterman osterman commented Mar 8, 2018 •
edited
Loading

what

  • Add table name output
  • Use ARN
  • Deprecate region
  • Use AWSServiceRoleForApplicationAutoScaling_DynamoDBTable arn

why

  • Name is useful for passing to other modules
  • Use ARN to be precise and reduce variables
  • Service Role needed for Idepotent executions

references

@osterman osterman requested a review from aknysh March 8, 2018 14:43
@goruha goruha self-requested a review March 8, 2018 14:52
@osterman osterman merged commit 95653fc into master Mar 8, 2018
@aknysh aknysh deleted the name-output branch March 23, 2018 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goruha goruha goruha approved these changes

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osterman @goruha