feat(log-forwarder): enable cache bucket for failed log events and dd tags #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/terratest |
|
/terratest |
goruha
approved these changes
Jul 2, 2024
|
These changes were released in v1.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Creates a bucket for storing Datadog Lambda tag cache (I'm not sure what this actually is) and storing log events which the lambda failed to post to DD.
See info here and here
why
We upgraded our lambda to the latest version published by DD and were receiving errors because DD_S3_BUCKET was unset, I investigated this functionality and implemented it in this module.