Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow full ARN for API key SSM param identifier #76

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

natw
Copy link
Contributor

@natw natw commented Apr 4, 2024

what

This expands the validation rules for the dd_api_key_source variable to allow you to provide the full ARN for a SSM parameter.

why

In the case where the parameter in question is shared from another account (via RAM), it has to be referenced using the full ARN.

references

https://docs.aws.amazon.com/systems-manager/latest/userguide/parameter-store-shared-parameters.html#accessing

@natw natw requested review from a team as code owners April 4, 2024 21:27
@natw natw requested review from nitrocode and gberenice April 4, 2024 21:27
@mergify mergify bot added the triage Needs triage label Apr 4, 2024
@gberenice
Copy link
Contributor

/terratest

@gberenice
Copy link
Contributor

@natw the tests are failing with :

Error: creating Lambda Function (eg-ue2-test-datadog-lambda-forwarder-lygfv1-logs): operation error Lambda: CreateFunction, https response error StatusCode: 400, RequestID: d2dfcadf-4a63-48ff-9199-dd7c687e672f, InvalidParameterValueException: The runtime parameter of python3.7 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (python3.12) while creating or updating functions.

Could you please update the default value for variable lambda_runtime to python3.12 :

variable "lambda_runtime" {
  type        = string
  description = "Runtime environment for Datadog Lambda"
  default     = "python3.12"
}

@natw
Copy link
Contributor Author

natw commented Apr 5, 2024

@gberenice as of lambda version 3.106.0, python 3.12 was giving me errors of some kind (sorry, it was a few weeks ago), but 3.11 worked fine, so I updated the default to that.

@gberenice
Copy link
Contributor

/terratest

@gberenice
Copy link
Contributor

/terratest

Copy link
Contributor

@gberenice gberenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @natw 👍

@gberenice gberenice merged commit 8c5f610 into cloudposse:main Apr 8, 2024
11 checks passed
@mergify mergify bot removed the triage Needs triage label Apr 8, 2024
@natw natw deleted the allow_api_key_arn branch May 21, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants